Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift 4.2 #46

Merged
merged 3 commits into from
Sep 28, 2018
Merged

Support Swift 4.2 #46

merged 3 commits into from
Sep 28, 2018

Conversation

djones6
Copy link
Contributor

@djones6 djones6 commented Sep 28, 2018

Description

Updates for Swift 4.2 to resolve compilation warnings. Specifically:

  • Removes the Swift 3 format Package.swift, since this package no longer supports Swift 3
  • Updates Package.swift to Swift 4.2 format, and renames the Package@Swift-4.x.swift -> Package@swift-4.x.swift (SPM otherwise does not pick these up),
  • Updates .swift-version to 4.2 and adjusts .travis.yml accordingly,
  • Defines the OpenSSL dependency as an embedded system library for 4.2,
  • Copies the module.modulemap and shim.h files from OpenSSL into a new target in this package,
  • Adds a errToString(ptr: UnsafeMutablePointer<Int8>?) -> String helper to avoid string interpolation warnings with optionals.

Motivation and Context

Resolves compiler warnings relating to the use of system packages with Swift 4.2.
(see: https://github.com/apple/swift-evolution/blob/master/proposals/0208-package-manager-system-library-targets.md)

Also resolves warnings due to string interpolation of UnsafeMutablePointer? in several error logging messages, which I suspect is related to the rework of implicitly unwrapped optionals: https://github.com/apple/swift-evolution/blob/master/proposals/0054-abolish-iuo.md

How Has This Been Tested?

Checklist:

  • I have submitted a CLA form
  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

Copy link
Collaborator

@billabt billabt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants